feat(NODE-3777): set tls options per kms provider #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
reviewed
Jan 17, 2022
durran
commented
Jan 19, 2022
bindings/node/index.d.ts
Outdated
| @@ -203,7 +203,13 @@ export interface ClientEncryptionOptions { | |||
| /** | |||
| * TLS options for kms providers to use. | |||
| */ | |||
| tlsOptions?: ClientEncryptionTLSOptions; | |||
| tlsOptions?: { | |||
There was a problem hiding this comment.
TLS options to KMS providers are configured on a per KMS provider basis for future flexibility.
durran
commented
Jan 19, 2022
durran
commented
Jan 19, 2022
durran
commented
Jan 19, 2022
5 tasks
addaleax
approved these changes
Jan 19, 2022
baileympearson
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note Prose and spec tests are located in the main Node repo. Related PR mongodb/node-mongodb-native#3070
Node CSFLE run against this specific branch: https://spruce.mongodb.com/version/61e753873066153369a025de/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC