New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSHARP-5035: Improve serverless tests to obtain secrets from vault #1314
Conversation
@@ -738,9 +738,6 @@ functions: | |||
- "FLE_AZURE_CLIENT_SECRET" | |||
- "FLE_GCP_EMAIL" | |||
- "FLE_GCP_PRIVATE_KEY" | |||
- "SERVERLESS_ATLAS_USER" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Credentials is being fetched from the vault now.
@@ -769,47 +766,6 @@ functions: | |||
FRAMEWORK=${FRAMEWORK} \ | |||
evergreen/run-tests.sh | |||
|
|||
create-serverless-instance: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've deleted create-serverless-instance
and delete-serverless-instance-if-configured
tasks by moving them into setup
and teardown
of serverless-task-group
.
@@ -1059,9 +1015,6 @@ pre: | |||
- func: make-files-executable | |||
|
|||
post: | |||
# Removed, causing timeouts | |||
# - func: upload-working-dir | |||
- func: delete-serverless-instance-if-configured |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do not need it here, because serverless tests have it's own task group now.
@@ -1279,7 +1232,6 @@ tasks: | |||
- name: test-serverless | |||
exec_timeout_secs: 2700 # 45 minutes: 15 for setup + 30 for tests | |||
commands: | |||
- func: create-serverless-instance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to setup
of serverless-task-group
.
@@ -2387,17 +2368,12 @@ buildvariants: | |||
- name: "test-load-balancer-netstandard21" | |||
|
|||
# Serverless tests | |||
- matrix_name: serverless-tests-windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some of evergreen-tools scripts were not happy with Windows host (I've got error: jq: command not found
). I think it should be enough to run serverless tests on Ubuntu only. But if it's vital for us to have Windows tests as well - I can dig deeper to understand what we can do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Good refactoring!
Just need to decide re. windows.
No description provided.