GODRIVER-2997 Prevent cancelable context in txn commit loop #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestonvasquez
requested review from
qingyang-hu
and removed request for
a team
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Error
prestonvasquez
had a problem deploying
to
api-report
GitHub Actions
Error
blink1073
pushed a commit
to blink1073/mongo-go-driver
that referenced
this pull request
Oct 10, 2023
rukumar333
pushed a commit
to mongodb-forks/mongo-go-driver
that referenced
this pull request
Oct 13, 2023
rukumar333
added a commit
to mongodb-forks/mongo-go-driver
that referenced
this pull request
Oct 13, 2023
dpish
pushed a commit
to mongodb-forks/mongo-go-driver
that referenced
this pull request
Jan 23, 2024
dpish
pushed a commit
to mongodb-forks/mongo-go-driver
that referenced
this pull request
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GODRIVER-2997
Summary
Use a background context when committing a transaction.
Background & Motivation
The Go Driver documentation for Session.WithTransaction notes that you should not use the method with a cancelable context:
Therefore, we should not honor user-defined contexts in the commit loop.