task: add go toolchain #2779
task: add go toolchain #2779
Conversation
| @@ -28,6 +28,7 @@ export PATH := $(shell go env GOPATH)/bin:$(PATH) | |||
| export PATH := ./bin:$(PATH) | |||
| export TERM := linux-m | |||
| export GO111MODULE := on | |||
| export GOTOOLCHAIN := local | |||
There was a problem hiding this comment.
I found the "auto" behavior with asdf to be dangerous as it installs versions within the version manager so avoiding issues here
There was a problem hiding this comment.
since go can be its own version manager let's forget about asdf
| @@ -2,6 +2,8 @@ module github.com/mongodb/mongodb-atlas-cli/atlascli | |||
|
|
|||
| go 1.22 | |||
There was a problem hiding this comment.
checked out to the branch and got:
- do we need to do any setup to be able to update master?
❯ make deps
==> Installing go.mod dependencies...
go mod download
go: go.mod requires go >= 1.22 (running go 1.21.1; GOTOOLCHAIN=local)
make: *** [deps] Error 1
There was a problem hiding this comment.
see #2779 (comment)
you need to install/set go1.22 however you are managing your go versions, I have swapped from asdf to using the homebrew version (asdf global golang system) but you can keep using asdf if that works for you
There was a problem hiding this comment.
ok, if I set asdf global golang system, I still get the error, but if we set go 1.22.1 at line 3 then it works!
There was a problem hiding this comment.
, I still get the error,
I can't reproduce before doing that change can you confirm you have updated your env correctly, as in reload the shell env, via something like source ~/.zshrc, or restarting your term, and if you still get an error what's the output of go env?
Please consider that
go 1.22.1
should be equivalent to
go 1.22
toolchain go1.22.1
There was a problem hiding this comment.
I think if it's not reproducible I can workaround to fix my machine, so I'll leave my stamp.
| @@ -2,6 +2,8 @@ module github.com/mongodb/mongodb-atlas-cli/atlascli | |||
|
|
|||
| go 1.22 | |||
There was a problem hiding this comment.
I think if it's not reproducible I can workaround to fix my machine, so I'll leave my stamp.
See golang/go#62278