CLOUDP-234797: Update docs about upgrades from replica sets to multi-… #2786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blva
commented
Mar 19, 2024
gssbzn
previously approved these changes
Mar 19, 2024
zach-carr
previously approved these changes
Mar 20, 2024
| @@ -18,6 +18,8 @@ You can specify modifications in a JSON configuration file with the --file flag. | |||
|
|
|||
| You can't change the name of the cluster or downgrade the MongoDB version of your cluster. | |||
|
|
|||
| You must not update a replica set to a multi-sharded cluster, only single-sharded cluster is supported. See https://www.mongodb.com/docs/atlas/scale-cluster/#convert-a-replica-set-to-a-sharded-cluster and https://www.mongodb.com/docs/upcoming/tutorial/convert-replica-set-to-replicated-shard-cluster for more information on this type of update. | |||
There was a problem hiding this comment.
Copy suggestions -- take a firm position that this isn't allowed (can not vs. must not), reorganize sentence structure a little bit to present more context to the user at the start of each one:
Suggested change
| You must not update a replica set to a multi-sharded cluster, only single-sharded cluster is supported. See https://www.mongodb.com/docs/atlas/scale-cluster/#convert-a-replica-set-to-a-sharded-cluster and https://www.mongodb.com/docs/upcoming/tutorial/convert-replica-set-to-replicated-shard-cluster for more information on this type of update. | |
| You can only update a replica set to a single-shard cluster; you cannot update a replica set to a multi-sharded cluster. | |
| To learn more, see https://www.mongodb.com/docs/atlas/scale-cluster/#convert-a-replica-set-to-a-sharded-cluster and https://www.mongodb.com/docs/upcoming/tutorial/convert-replica-set-to-replicated-shard-cluster. |
| @@ -146,6 +146,8 @@ func UpdateBuilder() *cobra.Command { | |||
|
|
|||
| You can't change the name of the cluster or downgrade the MongoDB version of your cluster. | |||
|
|
|||
| You must not update a replica set to a multi-sharded cluster, only single-sharded cluster is supported. See https://www.mongodb.com/docs/atlas/scale-cluster/#convert-a-replica-set-to-a-sharded-cluster and https://www.mongodb.com/docs/upcoming/tutorial/convert-replica-set-to-replicated-shard-cluster for more information on this type of update. | |||
There was a problem hiding this comment.
Same comment applies here if you change the other paragraph
Suggested change
| You must not update a replica set to a multi-sharded cluster, only single-sharded cluster is supported. See https://www.mongodb.com/docs/atlas/scale-cluster/#convert-a-replica-set-to-a-sharded-cluster and https://www.mongodb.com/docs/upcoming/tutorial/convert-replica-set-to-replicated-shard-cluster for more information on this type of update. | |
| You can only update a replica set to a single-shard cluster; you cannot update a replica set to a multi-sharded cluster. To learn more, see https://www.mongodb.com/docs/atlas/scale-cluster/#convert-a-replica-set-to-a-sharded-cluster and https://www.mongodb.com/docs/upcoming/tutorial/convert-replica-set-to-replicated-shard-cluster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sharded instances
Proposed changes
CLOUDP-234797
Checklist
make fmtand formatted my codeFurther comments