New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
task: validate import alias via importas #2804
Conversation
section-separators: | ||
- newLine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invalid config
govet: | ||
check-shadowing: true | ||
maligned: | ||
suggest-new: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invalid configs
skip-dirs: | ||
- internal/mocks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
invalid config
@@ -24,7 +24,7 @@ import ( | |||
akov2common "github.com/mongodb/mongodb-atlas-kubernetes/v2/pkg/api/v1/common" | |||
akov2status "github.com/mongodb/mongodb-atlas-kubernetes/v2/pkg/api/v1/status" | |||
"go.mongodb.org/atlas-sdk/v20231115008/admin" | |||
v1 "k8s.io/apimachinery/pkg/apis/meta/v1" | |||
apisv1 "k8s.io/apimachinery/pkg/apis/meta/v1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: this is not idiomatic in kube upstream, metav1
is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
@@ -30,7 +30,7 @@ import ( | |||
akov2common "github.com/mongodb/mongodb-atlas-kubernetes/v2/pkg/api/v1/common" | |||
akov2status "github.com/mongodb/mongodb-atlas-kubernetes/v2/pkg/api/v1/status" | |||
"go.mongodb.org/atlas-sdk/v20231115008/admin" | |||
v1 "k8s.io/apimachinery/pkg/apis/meta/v1" | |||
apisv1 "k8s.io/apimachinery/pkg/apis/meta/v1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
one comment about the |
@s-urbaniak RFAL |
Enable
importas
to force consistent import alias