Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLOUDP-239849: remove unused podman struct fields #2813

Merged
merged 2 commits into from Mar 28, 2024
Merged

CLOUDP-239849: remove unused podman struct fields #2813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7ebb7c
CLOUDP-239849: remove unused podman struct fields
tibulca Mar 27, 2024
8d36d21
CLOUDP-239849: remove unused podman struct fields
tibulca Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
21 changes: 12 additions & 9 deletions build/ci/evergreen.yml
View file
Open in desktop
Expand Up @@ -1075,6 +1075,8 @@ tasks:
E2E_PARALLEL: 16
- name: atlas_deployments_local_noauth_e2e
tags: ["e2e","deployments","local","noauth"]
# This test will be enabled in CLOUDP-237038
patch_only: true
must_have_test_results: true
exec_timeout_secs: 11400 # 3 hours 10 minutes
depends_on:
Expand Down Expand Up @@ -1107,6 +1109,8 @@ tasks:
E2E_TIMEOUT: 3h
- name: atlas_deployments_local_auth_e2e
tags: ["e2e","deployments","local","auth"]
# This test will be enabled in CLOUDP-237038
patch_only: true
must_have_test_results: true
exec_timeout_secs: 11400 # 3 hours 10 minutes
depends_on:
Expand Down Expand Up @@ -1280,14 +1284,13 @@ buildvariants:
<<: *go_linux_version
tasks:
- name: ".e2e .deployments .atlas"
# This variant will be enabled in CLOUDP-237038
# - name: e2e_local_deployments
# display_name: "E2E Local Deployments Tests"
# run_on:
# - rhel80-small
# expansions:
# <<: *go_linux_version
# tasks:
# - name: ".e2e .deployments .local"
- name: e2e_local_deployments
display_name: "E2E Local Deployments Tests"
run_on:
- rhel80-small
expansions:
<<: *go_linux_version
tasks:
- name: ".e2e .deployments .local"
include:
- filename: build/ci/release.yml
2 changes: 2 additions & 0 deletions internal/cli/deployments/options/deployment_opts_select.go
View file
Open in desktop
Expand Up @@ -22,6 +22,7 @@ import (
"strings"

"github.com/AlecAivazis/survey/v2"
"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/log"
"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/podman"
"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/telemetry"
"github.com/mongodb/mongodb-atlas-cli/atlascli/internal/usage"
Expand All @@ -35,6 +36,7 @@ var errDeploymentRequiredOnPipe = fmt.Errorf("deployment name is required when
func (opts *DeploymentOpts) findMongoDContainer(ctx context.Context) (*podman.InspectContainerData, error) {
containers, err := opts.PodmanClient.ContainerInspect(ctx, opts.LocalMongodHostname())
if err != nil {
_, _ = log.Debugf("Error: failed to retrieve Local deployments because %q\n", err.Error())
return nil, fmt.Errorf("%w: %s", ErrDeploymentNotFound, opts.DeploymentName)
}

Expand Down