CLOUDP-248054: Stop copying mongocli config into atlascli #2945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gssbzn
reviewed
May 13, 2024
Comment on lines
-109
to
-115
| _, err = os.Stat(atlasConfigHomePath) // check if the dir is already there | ||
| if err != nil { | ||
| defaultPermissions := 0700 | ||
| if err = os.Mkdir(atlasConfigHomePath, os.FileMode(defaultPermissions)); err != nil { | ||
| return | ||
| } | ||
| } |
There was a problem hiding this comment.
have you tried the changes locally with no folder present? I'm wondering if this is still needed when installing on a clean system
There was a problem hiding this comment.
yep, seems fine, here are some of the commands I tried in case I missed something:
- other commands
❯ ./bin/atlas deployments list
NAME TYPE MDB VER STATE
To list both local and cloud Atlas deployments, authenticate to your Atlas account using the "atlas login" command.
❯ ./bin/atlas clusters list
Error: this action requires authentication
To log in using your Atlas username and password, run: atlas auth login
To set credentials using API keys, run: atlas config init
❯ ./bin/atlas login
To verify your account, copy your one-time verification code:
KRMH-FY38
Paste the code in the browser when prompted to activate your Atlas CLI. Your code will expire after 10 minutes.
To continue, go to https://account.mongodb.com/account/connect
- list before deleting / init then list
❯ ./bin/atlas config list
PROFILE NAME
Usage: atlas config delete <name> [flags]
❯ ./bin/atlas config init
You are configuring a profile for atlas.
All values are optional and you can use environment variables (MONGODB_ATLAS_*) instead.
Enter [?] on any option to get help.
? Public API Key:
? Private API Key: [? for help]
? Default Project ID:
? Default Org ID:
? Default Output Format: plaintext
Your profile is now configured.
You can use [atlas config set] to change these settings at a later time.
❯ ./bin/atlas config list
PROFILE NAME
defaultThere was a problem hiding this comment.
can you do do mv ~/Library/Application\ Support/atlascli ~/Library/Application\ Support/atlasclibck before doing login? that's the part I'm curios, if the folder doesn't exists
There was a problem hiding this comment.
❯ mv ~/Library/Application\ Support/atlascli ~/Library/Application\ Support/atlasclibck
❯ ./bin/atlas login
To verify your account, copy your one-time verification code:
BVMR-QWR3
Paste the code in the browser when prompted to activate your Atlas CLI. Your code will expire after 10 minutes.
To continue, go to https://account.mongodb.com/account/connect
^C%
❯ ./bin/atlas clusters list
Error: this action requires authentication
To log in using your Atlas username and password, run: atlas auth login
To set credentials using API keys, run: atlas config init
❯ git pull
❯ ./bin/atlas config list
PROFILE NAME
There was a problem hiding this comment.
To continue, go to https://account.mongodb.com/account/connect
^C%
can you continue and see if the file is created? the thing to check if we need to pre create the folder or will it be created along the file, since you are deleting the code that created the folder before trying to create the file
There was a problem hiding this comment.
yep, worked fine!
❯ ./bin/atlas login
To verify your account, copy your one-time verification code:
Q9K3-J896
Paste the code in the browser when prompted to activate your Atlas CLI. Your code will expire after 10 minutes.
To continue, go to https://account.mongodb.com/account/connect
Successfully logged in as blvaguiar@gmail.com.
Select one default organization and one default project.
? Choose a default project: 623202922f697375cac9414a
You have successfully configured your profile.
You can use [atlas config set] to change your profile settings later.
❯ ./bin/atlas config list
PROFILE NAME
default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
CLOUDP-248054
Checklist
make fmtand formatted my codeFurther comments