Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLOUDP-248476: Apply SDLC checklist feedback #1571

Merged
merged 1 commit into from May 20, 2024

Conversation

josvazg
Copy link
Collaborator

@josvazg josvazg commented May 9, 2024

NOTE: Upload to Silk is pending (See CLOUDP-239190), once that is ready we will revisit the SBOMs linked to be the augmented ones.

All Submissions:

  • Have you signed our CLA?

@josvazg josvazg marked this pull request as draft May 9, 2024 09:46
@josvazg
Copy link
Collaborator Author

josvazg commented May 9, 2024

Will review comments on https://github.com/10gen/ops-manager-kubernetes/pull/3569 before coming back to this

@josvazg josvazg marked this pull request as ready for review May 9, 2024 10:05
@josvazg josvazg requested a review from s-urbaniak May 17, 2024 12:13
Copy link
Collaborator

@slaskawi slaskawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good the only bit that is missing and needs to be corrected is the signing verification manual. Let me know if you'd like to address this in a separate PR, so that I'll approve this one.

@josvazg
Copy link
Collaborator Author

josvazg commented May 20, 2024

Overall looks good the only bit that is missing and needs to be corrected is the signing verification manual. Let me know if you'd like to address this in a separate PR, so that I'll approve this one.

It is done, see line 28 and /docs/dev/signed-images.md

@josvazg josvazg requested a review from slaskawi May 20, 2024 12:01
@josvazg josvazg force-pushed the CLOUDP-248476/sdlc-feedback branch from e263890 to 0a12cf3 Compare May 20, 2024 12:11
@josvazg josvazg merged commit 4dceb0c into main May 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants