fix(NODE-1837): remove zstc level option

mongodb · May 16, 2022 · 1412056 · 1412056
1 parent 6992259
commit 1412056
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 38 deletions.
diff --git a/src/cmap/connection.ts b/src/cmap/connection.ts
@@ -795,10 +795,6 @@ function write(
     if (conn[kDescription].zlibCompressionLevel) {
       operationDescription.zlibCompressionLevel = conn[kDescription].zlibCompressionLevel;
     }
-
-    if (conn[kDescription].zstdCompressionLevel) {
-      operationDescription.zstdCompressionLevel = conn[kDescription].zstdCompressionLevel;
-    }
   }
 
   if (typeof options.socketTimeoutMS === 'number') {

diff --git a/src/cmap/message_stream.ts b/src/cmap/message_stream.ts
@@ -40,7 +40,6 @@ export interface OperationDescription extends BSONSerializeOptions {
   socketTimeoutOverride?: boolean;
   agreedCompressor?: CompressorName;
   zlibCompressionLevel?: number;
-  zstdCompressionLevel?: number;
   $clusterTime?: Document;
 }
 

diff --git a/src/cmap/stream_description.ts b/src/cmap/stream_description.ts
@@ -36,7 +36,6 @@ export class StreamDescription {
   __nodejs_mock_server__?: boolean;
 
   zlibCompressionLevel?: number;
-  zstdCompressionLevel?: number;
 
   constructor(address: string, options?: StreamDescriptionOptions) {
     this.address = address;

diff --git a/src/cmap/wire_protocol/compression.ts b/src/cmap/wire_protocol/compression.ts
@@ -34,6 +34,7 @@ export const uncompressibleCommands = new Set([
 ]);
 
 const MAX_COMPRESSOR_ID = 3;
+const ZSTD_COMPRESSION_LEVEL = 3;
 
 // Facilitate compressing a message using an agreed compressor
 export function compress(
@@ -68,7 +69,7 @@ export function compress(
       if ('kModuleError' in ZStandard) {
         return callback(ZStandard['kModuleError']);
       }
-      ZStandard.compress(dataToBeCompressed, self.options.zstdCompressionLevel).then(
+      ZStandard.compress(dataToBeCompressed, ZSTD_COMPRESSION_LEVEL).then(
         buffer => callback(undefined, buffer),
         error => callback(error)
       );

diff --git a/src/connection_string.ts b/src/connection_string.ts
@@ -1210,10 +1210,6 @@ export const OPTIONS = {
     default: 0,
     type: 'int'
   },
-  zstdCompressionLevel: {
-    default: 3,
-    type: 'int'
-  },
   // Custom types for modifying core behavior
   connectionType: { type: 'any' },
   srvPoller: { type: 'any' },

diff --git a/src/mongo_client.ts b/src/mongo_client.ts
@@ -127,32 +127,6 @@ export interface MongoClientOptions extends BSONSerializeOptions, SupportedNodeC
   compressors?: CompressorName[] | string;
   /** An integer that specifies the compression level if using zlib for network compression. */
   zlibCompressionLevel?: 0 | 1 | 2 | 3 | 4 | 5 | 6 | 7 | 8 | 9 | undefined;
-  /** An integer specifying zstd compression level. */
-  zstdCompressionLevel?:
-    | 0
-    | 1
-    | 2
-    | 3
-    | 4
-    | 5
-    | 6
-    | 7
-    | 8
-    | 9
-    | 10
-    | 11
-    | 12
-    | 13
-    | 14
-    | 15
-    | 16
-    | 17
-    | 18
-    | 19
-    | 20
-    | 21
-    | 22
-    | undefined;
   /** The maximum number of hosts to connect to when using an srv connection string, a setting of `0` means unlimited hosts */
   srvMaxHosts?: number;
   /**
@@ -684,7 +658,6 @@ export interface MongoOptions
         | 'tlsInsecure'
         | 'waitQueueTimeoutMS'
         | 'zlibCompressionLevel'
-        | 'zstdCompressionLevel'
       >
     >,
     SupportedNodeConnectionOptions {