fix(NODE-3624): Incorrect default aggregation generic type (#2987)

mongodb · Sep 27, 2021 · 440517e · 440517e
1 parent a8e9938
commit 440517e
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/src/collection.ts b/src/collection.ts
@@ -1366,7 +1366,7 @@ export class Collection<TSchema extends Document = Document> {
    * @param pipeline - An array of aggregation pipelines to execute
    * @param options - Optional settings for the command
    */
-  aggregate<T = TSchema>(
+  aggregate<T = Document>(
     pipeline: Document[] = [],
     options?: AggregateOptions
   ): AggregationCursor<T> {

diff --git a/test/types/community/collection/aggregate.test-d.ts b/test/types/community/collection/aggregate.test-d.ts
@@ -1,5 +1,5 @@
-import { expectType } from 'tsd';
-import { AggregationCursor, MongoClient } from '../../../../src/index';
+import { expectNotType, expectType } from 'tsd';
+import { AggregationCursor, MongoClient, Document } from '../../../../src/index';
 
 // collection.aggregate tests
 const client = new MongoClient('');
@@ -11,6 +11,10 @@ interface Payment {
 }
 const cursor: AggregationCursor<Payment> = collection.aggregate<Payment>([{}]);
 
+const payments = db.collection<Payment>('banking');
+expectType<AggregationCursor<Document>>(payments.aggregate());
+expectNotType<AggregationCursor<Payment>>(payments.aggregate());
+
 cursor.match({ bar: 1 }).limit(10);
 
 collection.aggregate([{ $match: { bar: 1 } }, { $limit: 10 }]);