chore: fix invalid use of typeof operator (#3076)

mongodb · Dec 13, 2021 · 9d84765 · 9d84765
1 parent 3c041f4
commit 9d84765
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -20,6 +20,7 @@
     "prettier/prettier": "error",
     "tsdoc/syntax": "warn",
     "no-console": "error",
+    "valid-typeof": "error",
     "eqeqeq": [
       "error",
       "always",

diff --git a/src/cmap/stream_description.ts b/src/cmap/stream_description.ts
@@ -55,16 +55,16 @@ export class StreamDescription {
 
   receiveResponse(response: Document): void {
     this.type = parseServerType(response);
-    RESPONSE_FIELDS.forEach(field => {
-      if (typeof response[field] != null) {
+    for (const field of RESPONSE_FIELDS) {
+      if (response[field] != null) {
         this[field] = response[field];
       }
 
       // testing case
       if ('__nodejs_mock_server__' in response) {
         this.__nodejs_mock_server__ = response['__nodejs_mock_server__'];
       }
-    });
+    }
 
     if (response.compression) {
       this.compressor = this.compressors.filter(c => response.compression?.includes(c))[0];