fix implicit type conversion issue in options parser

mongodb · Feb 9, 2022 · a9195e3 · a9195e3
1 parent 991c0eb
commit a9195e3
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 14 deletions.
diff --git a/src/connection_string.ts b/src/connection_string.ts
@@ -204,13 +204,24 @@ function getUint(name: string, value: unknown): number {
   return parsedValue;
 }
 
-
 function toArray<T>(value: T): T[];
 function toArray<T>(value: T[]): T[];
 function toArray<T>(value: T | T[]): T[] {
   return Array.isArray(value) ? value : [value];
 }
 
+function parseType(value: string): number | boolean | string {
+  try {
+    return getBoolean('', value);
+  } catch {
+    try {
+      return getInt('', value);
+    } catch {
+      return value;
+    }
+  }
+}
+
 function toRecord(value: string): Record<string, any> {
   const record = Object.create(null);
   const keyValuePairs = value.split(',');
@@ -219,18 +230,7 @@ function toRecord(value: string): Record<string, any> {
     if (value == null) {
       throw new MongoParseError('Cannot have undefined values in key value pairs');
     }
-    try {
-      // try to get a boolean
-      record[key] = getBoolean('', value);
-    } catch {
-      try {
-        // try to get a number
-        record[key] = getInt('', value);
-      } catch {
-        // keep value as a string
-        record[key] = value;
-      }
-    }
+    record[key] = value;
   }
   return record;
 }
@@ -632,7 +632,9 @@ export const OPTIONS = {
     target: 'credentials',
     transform({ options, values: [value] }): MongoCredentials {
       if (typeof value === 'string') {
-        value = toRecord(value);
+        value = Object.fromEntries(
+          Object.entries(toRecord(value)).map(([key, value]) => [key, parseType(value)])
+        );
       }
       if (!isRecord(value)) {
         throw new MongoParseError('AuthMechanismProperties must be an object');

diff --git a/test/tools/uri_spec_runner.ts b/test/tools/uri_spec_runner.ts
@@ -221,6 +221,12 @@ export function executeUriValidationTest(
           .to.have.nested.property(expectedProp)
           .deep.equal(optionValue);
         break;
+      case 'maxStalenessSeconds':
+        expectedProp = 'readPreference.maxStalenessSeconds';
+        expect(options, `${errorMessage} ${optionKey} -> ${expectedProp}`)
+          .to.have.nested.property(expectedProp)
+          .deep.equal(optionValue);
+        break;
 
       //** WRITE CONCERN OPTIONS **/
       case 'w':