Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-3633): add Socks5 support #3041

Merged
merged 11 commits into from Dec 21, 2021
Merged

feat(NODE-3633): add Socks5 support #3041

merged 11 commits into from Dec 21, 2021

Conversation

addaleax
Copy link
Contributor

@addaleax addaleax commented Nov 17, 2021 •
edited by nbbeeken

Description

What is changing?

Is there new documentation needed for these changes?

Yes. This adds connection string parameters and MongoClient options.

What is the motivation for this change?

See NODE-3633 and adjacent tickets

Double check the following

@addaleax addaleax mentioned this pull request Nov 17, 2021
Merged
1 task
@addaleax addaleax mentioned this pull request Nov 23, 2021
Merged
nbbeeken
nbbeeken requested changes Dec 1, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got some initial feedback for ya, its looking good, mostly nits. Also, feel free to rebase to pull in the test fix on main so we can get the ✅ I don't mind the files viewed getting messed up for that.

src/deps.ts Outdated Show resolved Hide resolved
.evergreen/socks5srv.py Outdated Show resolved Hide resolved
src/cmap/connect.ts Outdated Show resolved Hide resolved
src/cmap/connect.ts Show resolved Hide resolved
src/cmap/connect.ts Outdated Show resolved Hide resolved
src/cmap/connect.ts Outdated Show resolved Hide resolved
.evergreen/run-socks5-tests.sh Show resolved Hide resolved
addaleax added a commit to mongodb-js/drivers-evergreen-tools that referenced this pull request Dec 3, 2021
@addaleax
Add socks5srv.py helper script
5bb59b3 
- Spec PR: mongodb/specifications#1103
- Node.js driver PR that makes use of this script:
  mongodb/node-mongodb-native#3041
addaleax added a commit to mongodb-js/drivers-evergreen-tools that referenced this pull request Dec 3, 2021
@addaleax
Add socks5srv.py helper script
0c45338 
- Spec PR: mongodb/specifications#1103
- Node.js driver PR that makes use of this script:
  mongodb/node-mongodb-native#3041
@addaleax addaleax mentioned this pull request Dec 3, 2021
Merged
addaleax
addaleax commented Dec 3, 2021
View reviewed changes
.evergreen/socks5srv.py Outdated Show resolved Hide resolved
@addaleax addaleax changed the title [WIP] feat(NODE-3633): add Socks5 support feat(NODE-3633): add Socks5 support Dec 14, 2021
nbbeeken
nbbeeken reviewed Dec 17, 2021
View reviewed changes
.evergreen/run-custom-csfle-tests.sh Outdated Show resolved Hide resolved
.evergreen/config.yml Show resolved Hide resolved
@nbbeeken nbbeeken marked this pull request as ready for review December 17, 2021 16:31
@nbbeeken nbbeeken added the Team Review Needs review from team label Dec 17, 2021
nbbeeken
nbbeeken reviewed Dec 17, 2021
View reviewed changes
test/manual/socks5.test.js Outdated Show resolved Hide resolved
test/spec/uri-options/proxy-options.json Show resolved Hide resolved
src/mongo_client.ts Outdated Show resolved Hide resolved
src/connection_string.ts Outdated Show resolved Hide resolved
@nbbeeken nbbeeken requested a review from durran December 20, 2021 19:33
@nbbeeken nbbeeken mentioned this pull request Dec 20, 2021
Merged
nbbeeken
nbbeeken approved these changes Dec 20, 2021
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for all the effort on this!!

@nbbeeken nbbeeken merged commit 451627a into mongodb:main Dec 21, 2021
@addaleax addaleax deleted the 3633-dev branch December 21, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@durran durran durran approved these changes

@nbbeeken nbbeeken nbbeeken approved these changes

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
3 participants
@addaleax @durran @nbbeeken