fix(NODE-3843): make GridFSBucketWriteStream.prototype.end() return this for compat with community nodejs types
#3088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…his` for compat with @types/node@17.0.6
|
Please do review it and publish a new version. Affected projects are broken. |
baileympearson
approved these changes
Jan 4, 2022
durran
approved these changes
Jan 4, 2022
nbbeeken
changed the title
GridFSBucketWriteStream.prototype.end() return this for compat with @types/node@17.0.6GridFSBucketWriteStream.prototype.end() return this for compat with community nodejs types
|
Our plan is to release these changes in our next minor release, which we're targeting for Thursday. I'm going to go ahead and merge this into main but we can continue the conversation here as needed. In the meantime, would pinning the version of |
|
@baileympearson we pinned @types/node to < 17.0.6 in Mongoose, so I think it should work if this project pins in the meantime as well |
|
@baileympearson I can confirm that on my NestJS project which uses Mongoose 6.1.4, only <16.11.7 works. @types/node 17x has the problem |
7 tasks
This was referenced Jan 7, 2022
Volatus
added a commit
to AUBGTheHUB/website-2021
that referenced
this pull request
Jan 24, 2022
See: mongodb/node-mongodb-native#3088 Signed-off-by: Ismayil Mirzali <ismayilmirzeli@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently
GridFSBucketWriteStream.prototype.end()returnsvoid. https://github.com/DefinitelyTyped/DefinitelyTyped/pull/57473/files changed it so thatend()now must returnthis, which means Mongoose and the Node driver are now incompatible with @types/node@17.0.6. First noticed this hereWhat is changing?
See above
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Compilation fails with @types/node@17.0.6. I took a look and it looks like this change compiles fine with @types/node@16.x as well.
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>