Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-1837): add zstd compression option #3237

Merged
merged 11 commits into from May 18, 2022
Merged

feat(NODE-1837): add zstd compression option #3237

merged 11 commits into from May 18, 2022

Conversation

durran
Copy link
Member

@durran durran commented May 6, 2022 •
edited

Description

Adds Zstandard compression library.

What is changing?

A new compression option zstd. Uses the newly published @mongodb-js/zstd module.

Is there new documentation needed for these changes?

None

What is the motivation for this change?

NODE-1837

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

nbbeeken
nbbeeken requested changes May 10, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
src/cmap/wire_protocol/compression.ts Outdated Show resolved Hide resolved
src/cmap/wire_protocol/compression.ts Outdated Show resolved Hide resolved
src/cmap/wire_protocol/compression.ts Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.evergreen/run-tests.sh Show resolved Hide resolved
@durran durran marked this pull request as ready for review May 11, 2022 12:13
@durran durran requested a review from nbbeeken May 11, 2022 12:46
nbbeeken
nbbeeken requested changes May 11, 2022
View reviewed changes
.evergreen/generate_evergreen_tasks.js Outdated Show resolved Hide resolved
test/unit/cmap/wire_protocol/compression.test.ts Show resolved Hide resolved
src/cmap/wire_protocol/compression.ts Outdated Show resolved Hide resolved
@dariakp dariakp added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label May 12, 2022
@nbbeeken nbbeeken added Team Review Needs review from team and removed Primary Review In Review with primary reviewer, not yet ready for team's eyes labels May 16, 2022
baileympearson
baileympearson previously approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@baileympearson baileympearson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a high-level secondary review. Looks good, nice work Durran!

nbbeeken
nbbeeken approved these changes May 18, 2022
View reviewed changes
Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for all the final stretch work here to get the dependency in the right place! once CI is 🟢 feel free to merge if I don't get to it. LGTM

@durran durran merged commit 1261432 into main May 18, 2022
@durran durran deleted the NODE-1837 branch May 18, 2022 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbbeeken nbbeeken nbbeeken approved these changes

@baileympearson baileympearson baileympearson left review comments

Assignees
No one assigned
Labels
Team Review Needs review from team
Projects
None yet
Milestone
No milestone
4 participants
@durran @nbbeeken @baileympearson @dariakp