Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-3699): add support for comment field #3167

Merged
merged 54 commits into from Apr 1, 2022
Merged

feat(NODE-3699): add support for comment field #3167

merged 54 commits into from Apr 1, 2022

Commits on Mar 28, 2022

  1. Add 24 new crud test files

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    bbbd074 View commit details
    Browse the repository at this point in the history

  2. Add remaining 4 tests

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    87546ed View commit details
    Browse the repository at this point in the history

  3. feat: Add support for comment field in update operations

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    e0eb13f View commit details
    Browse the repository at this point in the history

  4. Sync change streams test with latest specs

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    49a9c48 View commit details
    Browse the repository at this point in the history

  5. fix: bring in latest versions of comment tests

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    911f5c4 View commit details
    Browse the repository at this point in the history

  6. fix: uncomment atomic operators check in update.ts

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    ac9fd81 View commit details
    Browse the repository at this point in the history

  7. resolve merge conflicts

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    a5e4de6 View commit details
    Browse the repository at this point in the history

  8. finish conflict

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    704764a View commit details
    Browse the repository at this point in the history

  9. fix: skip failing change stream tests

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    07df766 View commit details
    Browse the repository at this point in the history

  10. fix: address linting issues

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    d7d7d28 View commit details
    Browse the repository at this point in the history

  11. fix: skip change streams pre 4.4 test

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    6bb15ec View commit details
    Browse the repository at this point in the history

  12. docs: add docstring comments to 'comment' option

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    fec0040 View commit details
    Browse the repository at this point in the history

  13. fix: fix lint error in doc string

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    c3e7fc1 View commit details
    Browse the repository at this point in the history

  14. fix: check for 'undefined' in place of a falsy value

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    f95e8f2 View commit details
    Browse the repository at this point in the history

  15. fix: remove comment from DeleteStatement

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    097a5f1 View commit details
    Browse the repository at this point in the history

  16. fix: support change streams tests

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    8433c67 View commit details
    Browse the repository at this point in the history

  17. feat: support comment in change streams

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    a1137c4 View commit details
    Browse the repository at this point in the history

  18. convert change stream node specific test to TS

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    0cfbc2a View commit details
    Browse the repository at this point in the history

  19. fix: only add comment to getMore on server versions 4.4 and above

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    71f1775 View commit details
    Browse the repository at this point in the history

  20. fix: remove comment from get more for failiing test

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    8d4267c View commit details
    Browse the repository at this point in the history

  21. Fix broken unified change stream tests 

    Unified change stream tests were failing because our implementation of `createChangeStream` was
out of spec compliance.  Rather than simply performing the initial aggregate
command, it would perform the aggregate and the following getMore.  This caused
extra CommandStarted events to be emitted for the Node driver during change stream
tests.

This commit refactors AbstractCursor to have an `initialize` method that performs
cursor initialization.  This allows the UnifiedTestRunner to call `initialize` in
createChangeStream.
    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    2cdbf3b View commit details
    Browse the repository at this point in the history

  22. fix: address lint warning in entities.ts

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    d9d09ee View commit details
    Browse the repository at this point in the history

  23. fix: fix unit tests for get_more opreation

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    9744897 View commit details
    Browse the repository at this point in the history

  24. chore: remove old node_specific change stream tests

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    960e887 View commit details
    Browse the repository at this point in the history

  25. fix: misc changes before re-request review

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    016652a View commit details
    Browse the repository at this point in the history

  26. test: sync change stream, aggregate and find spec tests 

    mongodb/specifications#1161 updates the specs to
only send `comment` on getMore commands if the server version is >= 4.4.
Although this functionality was already implemented as a part of this PR,
the spec tests were not.

This commit brings in the spec affected spec tests.
    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    2c705ea View commit details
    Browse the repository at this point in the history

  27. misc changes

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    d999bcc View commit details
    Browse the repository at this point in the history

  28. test: add test for comments with falsy value

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    48cd535 View commit details
    Browse the repository at this point in the history

  29. fix: add run-on requirements to falsy values test

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    d16f651 View commit details
    Browse the repository at this point in the history

  30. fix: remove legacy (<3.2) logic from cursors

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    0da642f View commit details
    Browse the repository at this point in the history

  31. fix: update comment falsy values tests with more falsy values

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    14f2ea2 View commit details
    Browse the repository at this point in the history

  32. fix: Symbol() instead of Symbol.for()

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    2f810ac View commit details
    Browse the repository at this point in the history

  33. fix: add back if statement for failing tests

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    127f71b View commit details
    Browse the repository at this point in the history

  34. Add programatic unified test run for falsey comments 

    Co-authored-by: Bailey Pearson <baileympearson@users.noreply.github.com>
    @nbbeeken @baileympearson
    nbbeeken and baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    eb5069d View commit details
    Browse the repository at this point in the history

  35. fix: revert usage of applyComment

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    b160c55 View commit details
    Browse the repository at this point in the history

  36. test: use unified runner for falsy values test

    @baileympearson
    baileympearson committed Mar 28, 2022
    Configuration menu
    Copy the full SHA
    d3c20c5 View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2022

  1. fix: address lint issue

    @baileympearson
    baileympearson committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    056ddae View commit details
    Browse the repository at this point in the history

  2. fix: add runonrequirement to falsy values tests

    @baileympearson
    baileympearson committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    cf145bd View commit details
    Browse the repository at this point in the history

  3. chore: working builder - needs fixup

    @baileympearson
    baileympearson committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    0a7e38d View commit details
    Browse the repository at this point in the history

  4. fix: allow falsy values in change stream options

    @baileympearson
    baileympearson committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    fba5e13 View commit details
    Browse the repository at this point in the history

  5. fix: add change stream falsy tests

    @baileympearson
    baileympearson committed Mar 29, 2022
    Configuration menu
    Copy the full SHA
    d0dbaab View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2022

  1. wip - address comments pt 1

    @baileympearson
    baileympearson committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    f1b15f9 View commit details
    Browse the repository at this point in the history

  2. feat: add comment support to listCollections and listIndexes

    @baileympearson
    baileympearson committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    a74b530 View commit details
    Browse the repository at this point in the history

  3. fix: reorganize tests && add tests for listDatabases

    @baileympearson
    baileympearson committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    f180064 View commit details
    Browse the repository at this point in the history

  4. fix: move sinon stubbing into tests and revert changes to connection … 

    …string tests
    @baileympearson
    baileympearson committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    42147ee View commit details
    Browse the repository at this point in the history

  5. fix: address comments

    @baileympearson
    baileympearson committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    0bcdfc0 View commit details
    Browse the repository at this point in the history

  6. chore: add test case for positive and negative zero

    @baileympearson
    baileympearson committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    a5523e0 View commit details
    Browse the repository at this point in the history

  7. fix: run on requireemnts in change stream falsy tests

    @baileympearson
    baileympearson committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    459344d View commit details
    Browse the repository at this point in the history

  8. fix: use correct run on requirement for list* tests

    @baileympearson
    baileympearson committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    8aac554 View commit details
    Browse the repository at this point in the history

  9. wip

    @baileympearson
    baileympearson committed Mar 30, 2022
    Configuration menu
    Copy the full SHA
    ece725d View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2022

  1. fix: don't run chnage stream tests on shareded topology

    @baileympearson
    baileympearson committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    9def648 View commit details
    Browse the repository at this point in the history

  2. fix: remove only

    @baileympearson
    baileympearson committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    cd2707d View commit details
    Browse the repository at this point in the history

  3. fix: address Neal's latest comments

    @baileympearson
    baileympearson committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    8518dcd View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2022

  1. fix: address Daria's comments

    @baileympearson
    baileympearson committed Apr 1, 2022
    Configuration menu
    Copy the full SHA
    157c75d View commit details
    Browse the repository at this point in the history