Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-4031): options parsing for array options #3193

Merged
merged 3 commits into from Apr 18, 2022

Conversation

baileympearson
Copy link
Contributor

Description

What is changing?

#3138 broke options parsing for options that allow arrays of values. This PR reverts the breaking changes from #3138, and then fixes read preference tags parsing again.

Is there new documentation needed for these changes?

No.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

Copy link
Contributor

@nbbeeken nbbeeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good test coverage thanks!

@nbbeeken nbbeeken requested a review from durran April 14, 2022 16:46
@nbbeeken nbbeeken added the Team Review Needs review from team label Apr 14, 2022
@nbbeeken nbbeeken changed the title fix(NODE-4031): Fix options parsing for array options fix(NODE-4031): options parsing for array options Apr 18, 2022
@nbbeeken nbbeeken merged commit 4b2e3d1 into main Apr 18, 2022
@nbbeeken nbbeeken deleted the NODE-4031-fix-array-options-parsing branch April 18, 2022 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team Review Needs review from team
Projects
None yet
2 participants