Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-4229): bump maxWireVersion to 17 #3265

Merged
merged 1 commit into from
May 25, 2022
Merged

feat(NODE-4229): bump maxWireVersion to 17 #3265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/cmap/wire_protocol/constants.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
export const MIN_SUPPORTED_SERVER_VERSION = '3.6';
export const MAX_SUPPORTED_SERVER_VERSION = '5.1';
export const MAX_SUPPORTED_SERVER_VERSION = '6.0';
export const MIN_SUPPORTED_WIRE_VERSION = 6;
export const MAX_SUPPORTED_WIRE_VERSION = 14;
export const MAX_SUPPORTED_WIRE_VERSION = 17;
export const OP_REPLY = 1;
export const OP_UPDATE = 2001;
export const OP_INSERT = 2002;
Expand Down
6 changes: 3 additions & 3 deletions test/unit/assorted/wire_version.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const { isHello } = require('../../../src/utils');

const minCompatErrMsg = `minimum wire version ${
Number.MAX_SAFE_INTEGER - 1
}, but this version of the Node.js Driver requires at most 14`;
}, but this version of the Node.js Driver requires at most 17`;
const maxCompatErrMsg = `reports maximum wire version 1, but this version of the Node.js Driver requires at least 6`;

describe('Wire Protocol Version', () => {
Expand Down Expand Up @@ -36,7 +36,7 @@ describe('Wire Protocol Version', () => {
await mock.cleanup();
});

describe('minimum is greater than 14', () => {
describe('minimum is greater than max supported', () => {
it('should raise a compatibility error', async function () {
setWireProtocolMessageHandler(Number.MAX_SAFE_INTEGER - 1, Number.MAX_SAFE_INTEGER);

Expand All @@ -54,7 +54,7 @@ describe('Wire Protocol Version', () => {
});
});

describe('maximum is less than 2', () => {
describe('maximum is less than min supported', () => {
it('should raise a compatibility error', async function () {
setWireProtocolMessageHandler(1, 1);

Expand Down
8 changes: 4 additions & 4 deletions test/unit/cmap/wire_protocol/constants.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ describe('Wire Protocol Constants', function () {
});

describe('MAX_SUPPORTED_SERVER_VERSION', function () {
it('returns 5.1', function () {
expect(MAX_SUPPORTED_SERVER_VERSION).to.equal('5.1');
it('returns 6.0', function () {
expect(MAX_SUPPORTED_SERVER_VERSION).to.equal('6.0');
});
});

Expand All @@ -26,8 +26,8 @@ describe('Wire Protocol Constants', function () {
});

describe('MAX_SUPPORTED_WIRE_VERSION', function () {
it('returns 14', function () {
expect(MAX_SUPPORTED_WIRE_VERSION).to.equal(14);
it('returns 17', function () {
expect(MAX_SUPPORTED_WIRE_VERSION).to.equal(17);
});
});
});