Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-4081): fix and deprecate change stream resume options #3270

Merged
merged 12 commits into from
May 31, 2022
Merged

feat(NODE-4081): fix and deprecate change stream resume options #3270

merged 12 commits into from
May 31, 2022

Commits on May 31, 2022

  1. feat: fix resume options 

    - remove calls to Reflect from the resume options getter
- deprecate the ResumeOptions interface
- make use of ChangeStreamCursorOptions instead of ResumeOptions internally
    @baileympearson
    baileympearson committed May 31, 2022
    Configuration menu
    Copy the full SHA
    c3e568b View commit details
    Browse the repository at this point in the history

  2. add resume options tests

    @baileympearson
    baileympearson committed May 31, 2022
    Configuration menu
    Copy the full SHA
    9aa409b View commit details
    Browse the repository at this point in the history

  3. refactor logic in resumeOptions to match spec

    @baileympearson
    baileympearson committed May 31, 2022
    Configuration menu
    Copy the full SHA
    f1c48e3 View commit details
    Browse the repository at this point in the history

  4. fix lint warnings

    @baileympearson
    baileympearson committed May 31, 2022
    Configuration menu
    Copy the full SHA
    e0dfc4c View commit details
    Browse the repository at this point in the history

  5. rework tests to better align with spec algorithm

    @baileympearson
    baileympearson committed May 31, 2022
    Configuration menu
    Copy the full SHA
    8de822a View commit details
    Browse the repository at this point in the history

  6. chore: fix style inconsistencies in new test file

    @baileympearson
    baileympearson committed May 31, 2022
    Configuration menu
    Copy the full SHA
    11c20a8 View commit details
    Browse the repository at this point in the history

  7. chore: name describe according to testing conventions

    @baileympearson
    baileympearson committed May 31, 2022
    Configuration menu
    Copy the full SHA
    b960127 View commit details
    Browse the repository at this point in the history

  8. refactor: remove unnecessary condition in if-statement

    @baileympearson
    baileympearson committed May 31, 2022
    Configuration menu
    Copy the full SHA
    acfb9e8 View commit details
    Browse the repository at this point in the history

  9. test: add bson options tests to other context blocks

    @baileympearson
    baileympearson committed May 31, 2022
    Configuration menu
    Copy the full SHA
    c036d5d View commit details
    Browse the repository at this point in the history

  10. test: remove .only

    @baileympearson
    baileympearson committed May 31, 2022
    Configuration menu
    Copy the full SHA
    d92d393 View commit details
    Browse the repository at this point in the history

  11. address Neal's comment

    @baileympearson
    baileympearson committed May 31, 2022
    Configuration menu
    Copy the full SHA
    4f38419 View commit details
    Browse the repository at this point in the history

  12. remove empty test

    @baileympearson
    baileympearson committed May 31, 2022
    Configuration menu
    Copy the full SHA
    c07c532 View commit details
    Browse the repository at this point in the history