Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(NODE-4691): interrupt in-flight operations on heartbeat failure #3457

Merged
merged 18 commits into from
Nov 28, 2022
Merged

feat(NODE-4691): interrupt in-flight operations on heartbeat failure #3457

merged 18 commits into from
Nov 28, 2022

Commits on Nov 28, 2022

  1. unskip tests and update cmap runner to use interruptInUseConnections

    @baileympearson
    baileympearson committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    1b60b6c View commit details
    Browse the repository at this point in the history

  2. add poolcleared network error

    @baileympearson
    baileympearson committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    1e2cb07 View commit details
    Browse the repository at this point in the history

  3. refactor: make Pool.clear take options object

    @baileympearson
    baileympearson committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    c1d3285 View commit details
    Browse the repository at this point in the history

  4. feat: kill in-flight operations when monitor fails

    @baileympearson
    baileympearson committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    70c847d View commit details
    Browse the repository at this point in the history

  5. chore: fix lint

    @baileympearson
    baileympearson committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    1135d6c View commit details
    Browse the repository at this point in the history

  6. chore: fix unit tests

    @baileympearson
    baileympearson committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    7c7c607 View commit details
    Browse the repository at this point in the history

  7. chore: add link to follow up ticket in TODO

    @baileympearson
    baileympearson committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    ab16a2f View commit details
    Browse the repository at this point in the history

  8. add todo toconnection pool

    @baileympearson
    baileympearson committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    c7cda84 View commit details
    Browse the repository at this point in the history

  9. refactor: make new error subclass PoolClearedError

    @baileympearson
    baileympearson committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    97d72a7 View commit details
    Browse the repository at this point in the history

  10. address comments

    @baileympearson
    baileympearson committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    c987ade View commit details
    Browse the repository at this point in the history

  11. consolidate lb logic in pool clear 

    - moves all load balanced specific logic into the same if-statement
- throws an error if pool.clear() is called in lb mode without a serviceId.
  this should never happen, and previously we would fall through to non-lb
  mode logic.  With this change, we now get a meaningful error.
    @baileympearson
    baileympearson committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    8d181c0 View commit details
    Browse the repository at this point in the history

  12. update comments for interruptInUseConnections

    @baileympearson
    baileympearson committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    02f954a View commit details
    Browse the repository at this point in the history

  13. attach retryable write error label in constructor for error

    @baileympearson
    baileympearson committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    2ae7ae5 View commit details
    Browse the repository at this point in the history

  14. use checkIn in favor of manually emitting events

    @baileympearson
    baileympearson committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    4084018 View commit details
    Browse the repository at this point in the history

  15. Skip failing interrupt in use test on lb topologies

    @baileympearson
    baileympearson committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    2b6de4e View commit details
    Browse the repository at this point in the history

  16. remove unnecssary check in checkIn

    @baileympearson
    baileympearson committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    41c3781 View commit details
    Browse the repository at this point in the history

  17. add type annotation to function

    @baileympearson
    baileympearson committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    809803c View commit details
    Browse the repository at this point in the history

  18. remove TODO comment in connection pool

    @baileympearson
    baileympearson committed Nov 28, 2022
    Configuration menu
    Copy the full SHA
    6fa8e9b View commit details
    Browse the repository at this point in the history