Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NODE-4834): ensure that MessageStream is destroyed when connections are destroyed #3482

Merged
merged 37 commits into from
Dec 16, 2022
Merged

fix(NODE-4834): ensure that MessageStream is destroyed when connections are destroyed #3482

merged 37 commits into from
Dec 16, 2022

Commits on Dec 5, 2022

  1. fix(NODE-4834): Add calls to destroy kMessageStream

    @W-A-James
    W-A-James committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    4130597 View commit details
    Browse the repository at this point in the history

  2. test(NODE-4834): WIP - Start work on unit tests

    @W-A-James
    W-A-James committed Dec 5, 2022
    Configuration menu
    Copy the full SHA
    4c10235 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2022

  1. fix(NODE-4834): Add guards to onError, onClose, onTimeout

    @W-A-James
    W-A-James committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    b341938 View commit details
    Browse the repository at this point in the history

  2. test(NODE-4834): WIP progress on unit tests

    @W-A-James
    W-A-James committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    032de2d View commit details
    Browse the repository at this point in the history

  3. style(NODE-4834): Revert style changes

    @W-A-James
    W-A-James committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    f75e202 View commit details
    Browse the repository at this point in the history

  4. test(NODE-4834): Remove unit test 'only' annotations

    @W-A-James
    W-A-James committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    586c410 View commit details
    Browse the repository at this point in the history

  5. test(NODE-4834): move test to more appropriate position

    @W-A-James
    W-A-James committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    7a8d807 View commit details
    Browse the repository at this point in the history

  6. style(NODE-4834): Remove todo comment

    @W-A-James
    W-A-James committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    0c804a6 View commit details
    Browse the repository at this point in the history

  7. docs(NODE-4834): Add tsdoc comments for clarification on closed and d… 

    …estroyed flags and on{Error,Timeout,Close} event handlers
    @W-A-James
    W-A-James committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    4e5a9bb View commit details
    Browse the repository at this point in the history

  8. style(NODE-4834): Eslint fixes

    @W-A-James
    W-A-James committed Dec 6, 2022
    Configuration menu
    Copy the full SHA
    5ccb807 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2022

  1. test(NODE-4834): Change test descriptions to match testing standards … 

    …and terminology used in spec

Co-authored-by: Durran Jordan <durran@gmail.com>
    @W-A-James @durran
    W-A-James and durran committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    770d050 View commit details
    Browse the repository at this point in the history

  2. docs(NODE-4834): Update inline documentation to reference state rathe… 

    …r than explicit values
    @W-A-James
    W-A-James committed Dec 7, 2022
    Configuration menu
    Copy the full SHA
    92d577d View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2022

  1. fix(NODE-4834): Address review comments

    @W-A-James
    W-A-James committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    1ada8ca View commit details
    Browse the repository at this point in the history

  2. test(NODE-4834): FakeSocket now simulates IO delay

    @W-A-James
    W-A-James committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    21dc8b4 View commit details
    Browse the repository at this point in the history

  3. style(NODE-4834): Revert unintended style change

    @W-A-James
    W-A-James committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    f5f12f5 View commit details
    Browse the repository at this point in the history

  4. test(NODE-4834): Ensure that FakeSocket.end also sets this.writableEn… 

    …ded to true
    @W-A-James
    W-A-James committed Dec 8, 2022
    Configuration menu
    Copy the full SHA
    1e5d874 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2022

  1. fix(NODE-4834): Update Connection.destroy and event handler logic to … 

    …avoid race conditions on the this.closed flag
    @W-A-James
    W-A-James committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    f940281 View commit details
    Browse the repository at this point in the history

  2. test(NODE-4834): Add unit tests to check that options are treated cor… 

    …rectly in Connection.destroy
    @W-A-James
    W-A-James committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    927b883 View commit details
    Browse the repository at this point in the history

  3. fix(NODE-4834): Address eslint fixes

    @W-A-James
    W-A-James committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    bf1c8f0 View commit details
    Browse the repository at this point in the history

  4. docs(NODE-4834): Remove irrelevant docs

    @W-A-James
    W-A-James committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    452c1f0 View commit details
    Browse the repository at this point in the history

  5. style(NODE-4834): eslint fixes

    @W-A-James
    W-A-James committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    dcda86c View commit details
    Browse the repository at this point in the history

  6. refactor(NODE-4834): Make all paths through Connection.destroy async

    @W-A-James
    W-A-James committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    c74bff8 View commit details
    Browse the repository at this point in the history

  7. fix(NODE-4834): Address review comments

    @W-A-James
    W-A-James committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    7993c4e View commit details
    Browse the repository at this point in the history

  8. test(NODE-4834): Update old test

    @W-A-James
    W-A-James committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    e5c8e0a View commit details
    Browse the repository at this point in the history

  9. test(NODE-4834): remove 'only' annotation

    @W-A-James
    W-A-James committed Dec 12, 2022
    Configuration menu
    Copy the full SHA
    6540197 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2022

  1. test(NODE-4834): Fix failing tests

    @W-A-James
    W-A-James committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    7d43afb View commit details
    Browse the repository at this point in the history

  2. test(NODE-4834): remove debug messages

    @W-A-James
    W-A-James committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    2cdcc21 View commit details
    Browse the repository at this point in the history

  3. fix: only invoke callback when it is defined

    @nbbeeken
    nbbeeken committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    8d66f61 View commit details
    Browse the repository at this point in the history

  4. fix: lint

    @nbbeeken
    nbbeeken committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    44d5b05 View commit details
    Browse the repository at this point in the history

  5. rm: prints

    @nbbeeken
    nbbeeken committed Dec 13, 2022
    Configuration menu
    Copy the full SHA
    860d741 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2022

  1. test(NODE-4834): Update tests to be more coherent

    @W-A-James
    W-A-James committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    3b59a12 View commit details
    Browse the repository at this point in the history

  2. test(NODE-4834): Reorganize tests

    @W-A-James
    W-A-James committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    50fc706 View commit details
    Browse the repository at this point in the history

  3. test(NODE-4834): remove to.not.have.been.calledOnce instances

    @W-A-James
    W-A-James committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    a11a4f6 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. test(NODE-4834): Separate tests more cleanly

    @W-A-James
    W-A-James committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    23755ca View commit details
    Browse the repository at this point in the history

  2. test(NODE-4834): Split up tests more cleanly

    @W-A-James
    W-A-James committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    878c764 View commit details
    Browse the repository at this point in the history

  3. test(NODE-4834): fix test name typo

    @W-A-James
    W-A-James committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    995700b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into NODE-4834/destroy_message_stream_when_connec… 

    …tions_are_destroyed
    @nbbeeken
    nbbeeken committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    c0d0189 View commit details
    Browse the repository at this point in the history