test: added additional tests (#12)

mongodb · Mar 15, 2024 · 246f9ef · 246f9ef
1 parent 15bf38e
commit 246f9ef
Show file tree

Hide file tree

Showing 5 changed files with 328 additions and 35 deletions.
diff --git a/tools/cli/Makefile b/tools/cli/Makefile
@@ -63,7 +63,7 @@ list: ## List all make targets
 .PHONY: unit-test
 unit-test: ## Run unit-tests
 	@echo "==> Running unit tests..."
-	$(TEST_CMD) -race  ./...
+	$(TEST_CMD) -race -cover ./...
 
 .PHONY: gen-mocks
 gen-mocks: ## Generate mocks

diff --git a/tools/cli/go.mod b/tools/cli/go.mod
@@ -9,7 +9,6 @@ require (
 	github.com/stretchr/testify v1.9.0
 	github.com/tufin/oasdiff v1.10.11
 	go.uber.org/mock v0.4.0
-	golang.org/x/exp v0.0.0-20240119083558-1b970713d09a
 )
 
 require (

diff --git a/tools/cli/internal/cli/merge/merge_test.go b/tools/cli/internal/cli/merge/merge_test.go
@@ -15,13 +15,15 @@
 package merge
 
 import (
+	"fmt"
 	"testing"
 
 	"github.com/getkin/kin-openapi/openapi3"
 	"github.com/mongodb/openapi/tools/cli/internal/cli/flag"
 	"github.com/mongodb/openapi/tools/cli/internal/cli/validator"
 	"github.com/mongodb/openapi/tools/cli/internal/openapi"
 	"github.com/spf13/afero"
+	"github.com/stretchr/testify/require"
 	"github.com/tufin/oasdiff/load"
 	"go.uber.org/mock/gomock"
 )
@@ -56,6 +58,31 @@ func TestSuccessfulMerge_Run(t *testing.T) {
 	}
 }
 
+func TestNoBaseSpecMerge_PreRun(t *testing.T) {
+	externalPaths := []string{"external.json"}
+	opts := &Opts{
+		outputPath:    "foas.json",
+		externalPaths: externalPaths,
+	}
+
+	err := opts.PreRunE(nil)
+	require.Error(t, err)
+	require.EqualError(t, err, fmt.Sprintf("no base OAS detected. "+
+		"Please, use the flag %s to include the base OAS", flag.Base))
+}
+
+func TestNoExternalSpecMerge_PreRun(t *testing.T) {
+	opts := &Opts{
+		outputPath: "foas.json",
+		basePath:   "base.json",
+	}
+
+	err := opts.PreRunE(nil)
+	require.Error(t, err)
+	require.EqualError(t, err, fmt.Sprintf("no external OAS detected. "+
+		"Please, use the flag %s to include at least one OAS", flag.External))
+}
+
 func TestCreateBuilder(t *testing.T) {
 	validator.ValidateSubCommandsAndFlags(
 		t,
@@ -64,3 +91,40 @@ func TestCreateBuilder(t *testing.T) {
 		[]string{flag.Base, flag.External, flag.Output},
 	)
 }
+
+func TestOpts_PreRunE(t *testing.T) {
+	testCases := []struct {
+		wantErr       require.ErrorAssertionFunc
+		basePath      string
+		name          string
+		externalPaths []string
+	}{
+		{
+			wantErr:       require.Error,
+			basePath:      "test",
+			name:          "NoExternalPaths",
+			externalPaths: nil,
+		},
+		{
+			wantErr:       require.Error,
+			name:          "NoBasePath",
+			externalPaths: []string{"test"},
+		},
+		{
+			wantErr:       require.NoError,
+			basePath:      "../../../test/data/base.json",
+			name:          "Successful",
+			externalPaths: []string{"test"},
+		},
+	}
+
+	for _, tt := range testCases {
+		t.Run(tt.name, func(t *testing.T) {
+			o := &Opts{
+				basePath:      tt.basePath,
+				externalPaths: tt.externalPaths,
+			}
+			tt.wantErr(t, o.PreRunE(nil))
+		})
+	}
+}
diff --git a/tools/cli/internal/openapi/oasdiff.go b/tools/cli/internal/openapi/oasdiff.go
@@ -200,7 +200,15 @@ func (o OasDiff) mergeResponses() error {
 
 func (o OasDiff) mergeSchemas() error {
 	extSchemas := o.external.Spec.Components.Schemas
+	if len(extSchemas) == 0 {
+		return nil
+	}
+
 	baseSchemas := o.base.Spec.Components.Schemas
+	if len(baseSchemas) == 0 {
+		o.base.Spec.Components.Schemas = extSchemas
+		return nil
+	}
 
 	for k, schemaToMerge := range extSchemas {
 		if _, ok := baseSchemas[k]; !ok {