CLOUDP-225849: add merging logic #10

andreaangiolillo · 2024-03-13T17:13:19Z

Proposed changes

Jira ticket: CLOUDP-225849

Checklist

I have signed the MongoDB CLA
I have added tests that prove my fix is effective or that my feature works

Further comments

Next Steps

Adding the unit tests for the remaining merge functions

tools/cli/internal/openapi/errors/param_conflict_error.go

tools/cli/internal/openapi/errors/tag_conflict_error.go

gssbzn · 2024-03-14T15:00:21Z

tools/cli/internal/openapi/oasdiff.go

+	}
+
+	if o.base == nil || o.base.Spec == nil {
+		*o.base = *o.external


instead of pointer here make the receiver of the method a pointer, this is the preferred practice, also it's a code smell to mix pointer and non pointer receivers so they all should be pointers then

tools/cli/internal/openapi/oasdiff.go

tools/cli/internal/pointer/pointer.go

andreaangiolillo added 2 commits March 13, 2024 17:12

CLOUDP-225849: add merging logic

e98196e

Update oasdiff.go

67c7706

andreaangiolillo marked this pull request as ready for review March 14, 2024 09:11

andreaangiolillo requested a review from a team as a code owner March 14, 2024 09:11

Create oasdiff_test.go

ce72c50

andreaangiolillo marked this pull request as draft March 14, 2024 12:29

andreaangiolillo added 3 commits March 14, 2024 13:52

CLOUDP-225849: fixes

9fafa21

fixes

f90e689

Update oasdiff_test.go

3c51740

andreaangiolillo marked this pull request as ready for review March 14, 2024 14:49