New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Add the unit tests to the github action #11
Conversation
- name: Install gotest | ||
run: go install gotest.tools/gotestsum@ec99a250836f069a524bb9d9b5de0a7a96334ea7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use this in the cli to have the test summary with failures since gotestsum can produce xunit reports
feel free to use the simpler go test
command but I wonder if there's a nicer way to have a summary report of tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this https://github.com/smartystreets/goconvey may be a bit too much. xD
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah I don't have a strong opinion I feel in general GH actions lack a good way to represent test summaries, I don't quite like it on the CLI currently and I haven't really found something good enough to what I would expect (a list of tests and the result)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Gustavo Bazan <gus.bazan@hey.com>
Proposed changes
Checklist
Further comments