Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Remove unwanted code #15

Merged
merged 8 commits into from Mar 15, 2024
Merged

test: Remove unwanted code #15

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
17e3eaa
test: added additional tests
andreaangiolillo Mar 15, 2024
c101a73
Update go.mod
andreaangiolillo Mar 15, 2024
db0c97a
Merge remote-tracking branch 'origin/main' into add_unit_test_2
andreaangiolillo Mar 15, 2024
59f9849
Update merge_test.go
andreaangiolillo Mar 15, 2024
245fb65
addressed PR comments
andreaangiolillo Mar 15, 2024
a063b74
Update oasdiff_test.go
andreaangiolillo Mar 15, 2024
b8202d6
Merge remote-tracking branch 'origin/main' into add_unit_test_2
andreaangiolillo Mar 15, 2024
713f91e
test:removed unwanted code
andreaangiolillo Mar 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
22 changes: 0 additions & 22 deletions tools/cli/internal/cli/merge/merge_test.go
View file
Open in desktop
Expand Up @@ -20,7 +20,6 @@ import (

"github.com/getkin/kin-openapi/openapi3"
"github.com/mongodb/openapi/tools/cli/internal/cli/flag"
"github.com/mongodb/openapi/tools/cli/internal/cli/validator"
"github.com/mongodb/openapi/tools/cli/internal/openapi"
"github.com/spf13/afero"
"github.com/stretchr/testify/require"
Expand Down Expand Up @@ -71,27 +70,6 @@ func TestNoBaseSpecMerge_PreRun(t *testing.T) {
"Please, use the flag %s to include the base OAS", flag.Base))
}

func TestNoExternalSpecMerge_PreRun(t *testing.T) {
opts := &Opts{
outputPath: "foas.json",
basePath: "base.json",
}

err := opts.PreRunE(nil)
require.Error(t, err)
require.EqualError(t, err, fmt.Sprintf("no external OAS detected. "+
"Please, use the flag %s to include at least one OAS", flag.External))
}

func TestCreateBuilder(t *testing.T) {
validator.ValidateSubCommandsAndFlags(
t,
Builder(),
0,
[]string{flag.Base, flag.External, flag.Output},
)
}

func TestOpts_PreRunE(t *testing.T) {
testCases := []struct {
wantErr require.ErrorAssertionFunc
Expand Down