New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-225849: Add scaffolding of the openapi cli #2
Conversation
opts := &Opts{} | ||
|
||
cmd := &cobra.Command{ | ||
Use: "merge [base-spec] [spec-1] [spec-2] [spec-3] ... [spec-n]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let;s use flags, they are friendlier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will add the logic in a follow-up PR. Out of curiosity, how do you envision the usage of the command when we want to merge multiple specs into the base one? Based on your comment, I was thinking about moving the base spec to a flag and leaving the other as args. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
either same as you have here, first is base or --base
--external...
or something like that and why flags tend to be friendlier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ticket: CLOUDP-225849
Description
This PR adds the scaffolding of the openapi cli that we will use to merge OASes. In particular, this PR defines the cli builder and the
merge
command without any logic.Next steps