Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add mocking #9

Merged
merged 6 commits into from Mar 11, 2024
Merged

test: Add mocking #9

merged 6 commits into from Mar 11, 2024

Conversation

andreaangiolillo
Copy link
Collaborator

@andreaangiolillo andreaangiolillo commented Mar 11, 2024

Proposed changes

This PR adds mocking to the tools/cli

Checklist

  • I have signed the MongoDB CLA
  • I have added tests that prove my fix is effective or that my feature works

Further comments

@andreaangiolillo andreaangiolillo marked this pull request as ready for review March 11, 2024 13:52
@andreaangiolillo andreaangiolillo requested a review from a team as a code owner March 11, 2024 13:52
@@ -1,3 +1,17 @@
// Copyright 2024 MongoDB Inc

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[q] Not strictly related to this PR but was curious if there are alternatives to having a license header placed in all files, such as a LICENSE file at the root of the project.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for apache should be both

tools/cli/Makefile Outdated Show resolved Hide resolved
Co-authored-by: Gustavo Bazan <gus.bazan@hey.com>
Copy link
Collaborator

@gssbzn gssbzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@andreaangiolillo andreaangiolillo merged commit e73efbb into main Mar 11, 2024
2 checks passed
@andreaangiolillo andreaangiolillo deleted the test_add_mock branch March 11, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants