Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migratescloud_backup_snapshot_export_job to new auto-generated SDK #2255

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

EspenAlbert
Copy link
Collaborator

@EspenAlbert EspenAlbert commented May 8, 2024

Description

Migratescloud_backup_snapshot_export_job to new auto-generated SDK

Link to any related issue(s): CLOUDP-246318

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

Passing acc+mig tests:

image

@@ -56,8 +56,9 @@ func DataSource() *schema.Resource {
Elem: &schema.Resource{
Schema: map[string]*schema.Schema{
"export_id": {
Type: schema.TypeString,
Computed: true,
Type: schema.TypeString,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for reply from the Cloud Backup team on the status of this attribute

if err := d.Set("err_msg", exportJob.ErrMsg); err != nil {
return diag.Errorf("error setting `created_at` for snapshot export job (%s): %s", d.Id(), err)
}
// if err := d.Set("err_msg", exportJob.Err); err != nil {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for reply from the Cloud Backup team on the status of this attribute

@EspenAlbert EspenAlbert force-pushed the CLOUDP-246318_cloud_backup_snapshot_export_job branch from 66d56ad to c75f0a7 Compare May 9, 2024 08:10
Copy link
Contributor

This PR has gone 7 days without any activity and meets the project’s definition of "stale". This will be auto-closed if there is no new activity over the next 7 days. If the issue is still relevant and active, you can simply comment with a "bump" to keep it open, or add the label "not_stale". Thanks for keeping our repository healthy!

@github-actions github-actions bot added the stale label May 15, 2024
@EspenAlbert EspenAlbert added the not_stale Not stale issue or PR label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not_stale Not stale issue or PR stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants