New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Migrates federated_settings_org_rolemapping
to the new auto-generated SDK
#2261
chore: Migrates federated_settings_org_rolemapping
to the new auto-generated SDK
#2261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
.../service/federatedsettingsorgrolemapping/data_source_federated_settings_org_role_mappings.go
Show resolved
Hide resolved
...service/federatedsettingsorgrolemapping/resource_federated_settings_org_role_mapping_test.go
Outdated
Show resolved
Hide resolved
...l/service/federatedsettingsorgrolemapping/data_source_federated_settings_org_role_mapping.go
Show resolved
Hide resolved
} | ||
} | ||
|
||
sort.Sort(mRoleAssignment(roleAssignments)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
knit: i wouldn't have these empty lines or in next func
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed some empty lines in f605df2
Description
Migrates
federated_settings_org_rolemapping
to the new auto-generated SDKLink to any related issue(s): CLOUDP-246324
Waiting on #2258Type of change:
Required Checklist:
Further comments
Acceptance test: