Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrates federated_settings_org_rolemapping to the new auto-generated SDK #2261

Merged
merged 18 commits into from May 20, 2024

Conversation

EspenAlbert
Copy link
Collaborator

@EspenAlbert EspenAlbert commented May 9, 2024

Description

Migrates federated_settings_org_rolemapping to the new auto-generated SDK

Link to any related issue(s): CLOUDP-246324

Waiting on #2258

Type of change:

  • Bug fix (non-breaking change which fixes an issue). Please, add the "bug" label to the PR.
  • New feature (non-breaking change which adds functionality). Please, add the "enhancement" label to the PR. A migration guide must be created or updated if the new feature will go in a major version.
  • Breaking change (fix or feature that would cause existing functionality to not work as expected). Please, add the "breaking change" label to the PR. A migration guide must be created or updated.
  • This change requires a documentation update
  • Documentation fix/enhancement

Required Checklist:

  • I have signed the MongoDB CLA
  • I have read the contributing guides
  • I have checked that this change does not generate any credentials and that they are NOT accidentally logged anywhere.
  • I have added tests that prove my fix is effective or that my feature works per HashiCorp requirements
  • I have added any necessary documentation (if appropriate)
  • I have run make fmt and formatted my code
  • If changes include deprecations or removals, I defined an isolated PR with a relevant title as it will be used in the auto-generated changelog.
  • If changes include removal or addition of 3rd party GitHub actions, I updated our internal document. Reach out to the APIx Integration slack channel to get access to the internal document.

Further comments

Acceptance test:

go test -timeout 2400s -run ^TestAccFederatedSettingsOrgRoleMapping_basic$ github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsorgrolemapping -v

=== RUN   TestAccFederatedSettingsOrgRoleMapping_basic
=== PAUSE TestAccFederatedSettingsOrgRoleMapping_basic
=== CONT  TestAccFederatedSettingsOrgRoleMapping_basic
--- PASS: TestAccFederatedSettingsOrgRoleMapping_basic (16.72s)
PASS
ok      github.com/mongodb/terraform-provider-mongodbatlas/internal/service/federatedsettingsorgrolemapping     17.835s

Base automatically changed from CLOUDP-248288_role_mapping_id to master May 10, 2024 14:16
@EspenAlbert EspenAlbert marked this pull request as ready for review May 10, 2024 15:23
@EspenAlbert EspenAlbert requested a review from a team as a code owner May 10, 2024 15:23
Copy link

@lmkerbey-mdb lmkerbey-mdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@EspenAlbert EspenAlbert added the not_stale Not stale issue or PR label May 15, 2024
}
}

sort.Sort(mRoleAssignment(roleAssignments))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

knit: i wouldn't have these empty lines or in next func

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed some empty lines in f605df2

@EspenAlbert EspenAlbert merged commit 319b4de into master May 20, 2024
2 checks passed
@EspenAlbert EspenAlbert deleted the 246324_federated_settings_org_rolemapping branch May 20, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not_stale Not stale issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants