Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the example folder #581

Merged
merged 2 commits into from
Dec 1, 2021
Merged

Update the example folder #581

merged 2 commits into from
Dec 1, 2021

Conversation

yahiakr
Copy link
Collaborator

@yahiakr yahiakr commented Nov 29, 2021

Checklist: #576.

Re-write the example in TS, & update its dependencies.

@yahiakr yahiakr mentioned this pull request Nov 29, 2021
13 tasks
@guumaster
Copy link
Member

Is it possible to keep both example functional? maybe some people still want to use it in Node without Typescript.

@yahiakr
Copy link
Collaborator Author

yahiakr commented Nov 29, 2021

Is it possible to keep both example functional? maybe some people still want to use it in Node without Typescript.

I was thinking about creating two examples in both languages, i will update it.

@guumaster
Copy link
Member

guumaster commented Nov 29, 2021

Is it possible to keep both example functional? maybe some people still want to use it in Node without Typescript.

I was thinking about creating two examples in both languages, i will update it.

yes, two folders sounds great! 👍

Maybe with this structure:

root/ 
  examples/
     node/
     typescript/

@yahiakr
Copy link
Collaborator Author

yahiakr commented Nov 29, 2021

yes, two folders sounds great! 👍

Maybe with this structure:

root/ 
  examples/
     node/
     typescript/

I did it at the project level by creating two folders /javascript & /typescript, since they share the same static resources.

@guumaster
Copy link
Member

yes, two folders sounds great! +1
Maybe with this structure:

root/ 
  examples/
     node/
     typescript/

I did it at the project level by creating two folders /javascript & /typescript, since they share the same static resources.

Even better this way! I'll checkout and run both later

@guumaster guumaster merged commit e2ef20a into mongoosastic:develop Dec 1, 2021
guumaster pushed a commit that referenced this pull request Mar 16, 2022
feat(example): add JS & TS examples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants