Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate github actions CI #587

Merged
merged 3 commits into from
Mar 3, 2022
Merged

Integrate github actions CI #587

merged 3 commits into from
Mar 3, 2022

Conversation

yahiakr
Copy link
Collaborator

@yahiakr yahiakr commented Mar 3, 2022

Checklist: #576.

  • Refactor createMapping method: instead of creating an index with custom settings, then update it to add the mapping (two separate actions), we specify the settings & the mappings when creating the index (one operation).
  • Remove unnecessary/duplicated test in test/index.test.ts, testing the createMapping method.
  • Add github actions CI

@yahiakr yahiakr mentioned this pull request Mar 3, 2022
13 tasks
@guumaster guumaster merged commit 8f64e2f into develop Mar 3, 2022
@yahiakr yahiakr deleted the feat/add-ci-workflow branch March 7, 2022 14:03
guumaster pushed a commit that referenced this pull request Mar 16, 2022
* refactor(statics/createMapping): create index with generated mapping, instead of updating it

* tests: add some comments about ES v8 compatibility

* feat(ci): add CI workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants