New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the error of generating cpu operations #21607

Open

Xinlong-Wu wants to merge 1 commit into mono:main from Xinlong-Wu:fix_mini_ops_h

Xinlong-Wu commented Jan 18, 2023

in the file mini-ops.h, TARGET_ARM64 has defined following OPs:

#ifdef TARGET_ARM64
MINI_OP(OP_LSCNT32, "lscnt32", IREG, IREG, NONE)
MINI_OP(OP_LSCNT64, "lscnt64", LREG, LREG, NONE)
MINI_OP(OP_ARM64_SMULH, "arm64_smulh", LREG, LREG, LREG)
MINI_OP(OP_ARM64_UMULH, "arm64_umulh", LREG, LREG, LREG)
#endif // TARGET_ARM64

but genmdesc.py can't parse it correctly and these four OPs will be generated in every arch.

This patch try to fix it

Xinlong-Wu requested review from vargaz, lambdageek and SamMonoRT as code owners

January 18, 2023 07:35


          fix format of ops definations of ARM64

899f1a5

Xinlong-Wu force-pushed the fix_mini_ops_h branch from 2093ba5 to 899f1a5 Compare

January 18, 2023 09:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment