PE loader: handle EINTR properly #21639
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open() may fail if process receives signal and open() requires blocked IO wait, like in case FS structures needed to open file are not cached at that moment. Proper way to handle such situation is to repeat operation if errno == EINTR.
Note that there're cases when Mono doing this correctly, like here: https://github.com/mono/mono/blob/main/mono/metadata/w32file-unix.c#L285 but its not doing this in the PE-loader's open(), that happen to fail sporadically with such error in our case. So this PR adds looping while (errno == EINTR) in this and similar places.