New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using syscall (SYS_fork) instead of fork(2) is a concession to glibc;… #21718

Open

rfht wants to merge 1 commit into mono:main from rfht:master

Contributor

rfht commented Oct 28, 2023

… consequently let !linux arches use fork(2). Necessary now on OpenBSD where syscall(2) access is deprecated. See comment about glibc:

mono/mono/mini/mini-posix.c

Line 900 in 89f1d3c

* glibc fork acquires some locks, so if the crash happened inside malloc/free,


          using syscall (SYS_fork) instead of fork(2) is a concession to glibc;…

ae5e8ab

… consequently let !__linux__ arches use fork(2). Necessary now on OpenBSD where syscall(2) access is being remove. See comment about glibc: https://github.com/mono/mono/blob/89f1d3cc22fd3b0848ecedbd6215b0bdfeea9477/mono/mini/mini-posix.c#L900

rfht requested review from vargaz, lambdageek and SamMonoRT as code owners

October 28, 2023 14:24

vargaz approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment