Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle batch to send them async #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle batch to send them async #23

wants to merge 1 commit into from

Conversation

gmponos
Copy link
Member

@gmponos gmponos commented Jun 26, 2020

No description provided.

@savvasal
Copy link
Contributor

This looks client's responsibility. Also in order to do this we will need to require guzzle and the way that is implemented is skipping the handling

@savvasal
Copy link
Contributor

savvasal commented Jun 26, 2020

This looks client's responsibility. Also in order to do this we will need to require guzzle and the way that is implemented is skipping the handling

For example a BatchAsyncClient that is doing something like this

    public function sendRequest(\Psr\Http\Message\RequestInterface $request): \Psr\Http\Message\ResponseInterface
    {
        $this->requests[] = $request;

        return new \GuzzleHttp\Psr7\Response();
    }

    public function sendAsyncBatchRequests(): array
    {
        return Pool::batch($this->client, $this->requests, $this->options);
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants