Package e2e testing #402
Merged
Package e2e testing #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
5 tasks
jinmayamashita
commented
Jan 23, 2023
| @@ -1,5 +1,6 @@ | |||
| { | |||
| "$schema": "https://turbo.build/schema.json", | |||
| "globalEnv": ["CI"], | |||
There was a problem hiding this comment.
jinmayamashita
commented
Jan 23, 2023
| "test": "turbo run build test --filter=!reactjs-boilerplate", | ||
| "test": "turbo run build --filter=create-codes test --filter=create-codes", |
There was a problem hiding this comment.
Only now, no other testing is involved except for the cli program testing.
jinmayamashita
commented
Jan 23, 2023
jinmayamashita
commented
Jan 23, 2023
jinmayamashita
commented
Jan 23, 2023
| "@types/node": "18.11.18", | ||
| "@types/react": "18.0.27", | ||
| "@types/react-dom": "18.0.10", | ||
| "@types/testing-library__jest-dom": "5.14.5", |
There was a problem hiding this comment.
Since we do not plan to use jest globally in the future, we will avoid the type error by adding the primary type once.
|
Looks like the e2e test was a success with CI
https://github.com/monstar-lab-oss/reactjs-boilerplate/actions/runs/3987218590/jobs/6836745980 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #391
What I did
Package the e2e test that is running now.
How to test
If your answer is yes to any of these, please make sure to include it in your PR.