Remove ubuntu 16.04 from self-tests, out of support #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OT: had to rerun the GHA workflow because one of the jobs failed (crash). It seems that there is some randomness right now. See https://github.com/stronk7/moodle-plugin-ci/actions?query=branch%3Abye_ubuntu_16_04++ , it happened the same (different branches affected) while preparing the PR (I did some changes disabling coverage to see if it was related or no). At the end, it passes... but not nice... going to rerun the workflow a number of times. |
|
Yeah, have run it 3 times:
I'm going to remove the new php80 jobs from the matrix, so this will be, exclusively, about to move to 20.04 |
And being removed from the GHA setup-php https://github.com/shivammathur/setup-php shivammathur/setup-php#452 So, jumping to 20.04
stronk7
force-pushed
the
bye_ubuntu_16_04
branch
from
51a959b
to
405b4ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And being removed from the GHA setup-php
https://github.com/shivammathur/setup-php
shivammathur/setup-php#452
So, jumping to 20.04
and also adding some mising php80 runs.