New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add @math.Unity
#325
base: main
Are you sure you want to change the base?
Add @math.Unity
#325
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #325 +/- ##
==========================================
+ Coverage 84.55% 84.72% +0.17%
==========================================
Files 73 74 +1
Lines 2874 2874
==========================================
+ Hits 2430 2435 +5
+ Misses 444 439 -5 ☔ View full report in Codecov by Sentry. |
This PR adds a
Unity
trait that provides integer types' unity value (a.k.a.1
). This is also applied onRef::incr()
andRef::decr()
to replace the hard-coded1
value. As a result, these two interfaces won't supportDouble
anymore because1.0
is not strictly a unity value of floating-point numbers.Depends on:
@num.Num
into@math.Num
parts #165