New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweak Vec.map/mapi #381
tweak Vec.map/mapi #381
Conversation
Important Auto Review SkippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
=======================================
Coverage 90.56% 90.56%
=======================================
Files 96 96
Lines 3602 3604 +2
=======================================
+ Hits 3262 3264 +2
Misses 340 340 ☔ View full report in Codecov by Sentry. |
inspect(v.map(fn(x) { x.to_string() }), content="Vec::[3, 4, 5]")? | ||
inspect(e.map(fn(x) { x + 1 }), content="Vec::[]")? | ||
// Is it correct? | ||
inspect(Vec::["a", "b", "c"], content="Vec::[a, b, c]")? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// Is it correct?
inspect(Vec::["a", "b", "c"], content="Vec::[a, b, c]")?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a known issue in current derived Show. cc @Guest0x0
inspect(v.map(fn(x) { x.to_string() }), content="Vec::[3, 4, 5]")? | ||
inspect(e.map(fn(x) { x + 1 }), content="Vec::[]")? | ||
// Is it correct? | ||
inspect(Vec::["a", "b", "c"], content="Vec::[a, b, c]")? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is a known issue in current derived Show. cc @Guest0x0
Do you have a name for that? |
I have two options.
|
map_inplace lgtm |
The behavior of map/mapi is not normal in Vec, they are not immutable.
At the same time, I would like to inquire whether the map implemented by this inplace should be implemented?