Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added css fill support for svg as a color value #2522

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jmarikle
Copy link

Added css support for the fill property associated with inline SVGs.

This is to correct issue #2521

@ibolmo ibolmo added this to the 1.6 milestone Mar 3, 2014
@ibolmo
Copy link
Member

ibolmo commented Mar 17, 2014

Missing specs which check for fill support.

@jmarikle
Copy link
Author

@ibolmo I apologize, but I don't know where those specs would be added. I See that some values are checked throughout this file but I don't see a consolidated location or standard method for such checks. I looked at a few of the surrounding files too but found nothing. Could you possibly point me to where a fill support check should be added?

@ibolmo
Copy link
Member

ibolmo commented Mar 27, 2014

You'll add the specs here: https://github.com/mootools/mootools-core/blob/master/Specs/Element/Element.Style.js

Should be much easier to contribute specs after the massive re-do to our testing platform. Let me know (us) if you still need some guidance.

TY!

@SergioCrisostomo
Copy link
Member

@jmarikle44i could you adapt this fiddle (http://jsfiddle.net/9V7zd/) to show the problem/solution better? then we can bild a specs from this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants