Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Type object from the public API #2825

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AmraniCh
Copy link

First, I want to congratulate you all on working so hard for making this great library.

Summary

When I was looking in the Core.js I've noticed that the Type object is not mentioned in the Mootools official documentation in the core section (except once used in one example on the Array page), although it is available to the end-users. The Type object offers only the Type.is[Type] functions to check the passed object type, which can be achieved using the Mootools typeOf function or even using the TypeInstance.$family function that injected to all the native JavaScript types defined by ECMA spec.

Suggestion

The Type object must be for the internal usage only, In order to clear up any confusion for library users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant