New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep settlement date when parsing files. #960
Conversation
Codecov Report
@@ Coverage Diff @@
## master #960 +/- ##
==========================================
+ Coverage 91.32% 92.22% +0.89%
==========================================
Files 66 66
Lines 5247 6060 +813
==========================================
+ Hits 4792 5589 +797
- Misses 282 295 +13
- Partials 173 176 +3 |
1998e0f
to
acdfe2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two minor suggestions, but looks good!
Co-authored-by: Vincent Xiao <vincentx72@gmail.com>
Co-authored-by: Vincent Xiao <vincentx72@gmail.com>
Appreciate the PR @eweise , I'm going to merge this in! |
Awesome. Thank you both |
No description provided.