Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Spanner as a data repository #220

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Add support for Spanner as a data repository #220

wants to merge 4 commits into from
+193 −6

Conversation

kevinbarbour
Copy link
Contributor

Changes

Add support for using Google Cloud Spanner instead of MySQL as a data repository for the achgateway.

@kevinbarbour kevinbarbour marked this pull request as draft January 10, 2024 21:03
adamdecaf
adamdecaf reviewed Jan 12, 2024
View reviewed changes
assets.go Outdated Show resolved Hide resolved
@kevinbarbour
Copy link
Contributor Author

Thanks for reviewing this @adamdecaf

Still leaving as a draft for now until I get our internal deployments set up and verify the Spanner DML works as expected, then will mark as ready to go!

@adamdecaf
Copy link
Member

Sounds good. Let me know how the testing goes!

@adamdecaf
Copy link
Member

@kevinbarbour Any update on testing this?

@kevinbarbour
Copy link
Contributor Author

Hey Adam, thanks for checking in. I should have this deployed and tested in the next week or so and we'll be able to get this merged.

@adamdecaf
Copy link
Member

Any updates?

@thejeff77
Copy link

Still in progress. I know he's working hard on it. Definitely should follow up before end of next week. Thanks for keeping tabs on it.

@adamdecaf
Copy link
Member

There are enough changes pending in achgateway I'm going to release them without adding Spanner. We can easily release achgateway with Spanner when it's ready.

@adamdecaf
Copy link
Member

How's testing going with this?

@kevinbarbour
Copy link
Contributor Author

Hey Adam, sorry for the delay again. We had some project priorities shift around and this has taken a backseat but I should be able to focus on our rollout of this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdecaf adamdecaf adamdecaf approved these changes

@thejeff77 thejeff77 thejeff77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevinbarbour @adamdecaf @thejeff77