Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unexpected listbox role from autowhatever items container. Fix #701 #830

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thibaudcolas
Copy link
Contributor

@thibaudcolas thibaudcolas commented Oct 12, 2021

This fixes #701. Currently this can be done per-project with renderSuggestionsContainer, but there is no reason for this container to have a listbox role to start with since the list within already does.

Once this is fixed, I believe #770 will be the only bug preventing this project from really following WAI-ARIA combobox markup to the letter.

…oroshko#701

This fixes moroshko#701. This can be customised per-project with `renderSuggestionsContainer`, but here is no reason for this container to have a `listbox` role to start with since the list within already does.
@danielbick
Copy link

Hello, is there any chance that this is still going to be merged given the almost one year anniversary of this PR @pimterry? 🙏

@pimterry
Copy link
Collaborator

I only briefly helped with maintenance a while back, when there was a particular backlog, I'm not actively maintaining this project. I'm afraid I don't have time to look into this change and confirm whether it's correct or whether it has other consequences.

As noted at the top of the README this project is looking for maintainers! If you or anybody else wants to take it on, send a message to moroshko on Twitter.

@david-buck
Copy link

This and #770 are vital for fixing some accessibility issues and some other unexpected behaviours.

I have reached out to moroshko on twitter to see if there’s a way we can merge a couple of these important PRs without agreeing to take over the project. I’m happy to help but not super capable. @thibaudcolas would you also be available to help?

@thibaudcolas
Copy link
Contributor Author

@david-buck yeah I can certainly help land those two pull requests, and perhaps a few other ones, if we’re able to do so. The project tooling is pretty similar to other ones I’ve worked on so it should be no problem. Looks like the only access needed would be to the GitHub repository to create releases there for the release notes like past releases, and then npm to publish the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

role="listbox" both on suggestionsContainer as well as suggestion ul
4 participants