-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #36 - 'Attribute redefined' problem #50
base: master
Are you sure you want to change the base?
Conversation
Can you please fix those style quirks, there is a .eslint file you can use for this! |
I've already update it bro. Please check. |
thanks.. hmm, but there seems something wrong, the tests are failing: can you please check why !? |
It failed since I run test on your original source code. I don't have any idea for now. |
I've fix some of your test just to make it pass. I don't know if that was the correct behaviour. |
Hi @moszeed, could you help me to merge this PR if there is no more issue? Our team need to use this libs as soon as possible. Thanks. |
Hi @moszeed. Are you still maintain this libs? How can we help you to maintain this repo? |
Hi, yes i still maintain this repo.. so keep the styling as is ... 🙏 |
We're already use your eslint config and that was the result. Any idea? |
You have error in your code. In file
and then you add this string one more time to
After that there is an error "Attribute redefined" |
I update this libs to fix Attribute Redefined problem on "xmlns:SOAP-ENV". We use different style configuration on our editor, so sorry for a lot of line arrangement. Thanks.