Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2/2] fixes dotenv-expand/config with env or cli args #78

Merged
merged 1 commit into from Aug 30, 2022

Conversation

lnasc256
Copy link
Contributor

I discovered that when using dotenv-expand in preload env and cli args are not working, so I made two pull requests (the former in dotenv and the latter in dotenv-expand to fix it.

I used dotenv#355 for reference.

@andrei-piatrou
Copy link

is there a change to get merged this one? really need this feature for dotenv-expand as well

@davemo
Copy link

davemo commented Aug 29, 2022

Yes, if this one is green it would be great to get it merged and a release cut. The downstream bug in Vite because of this is pretty frustrating: vitejs/vite#6626

@motdotla
Copy link
Owner

motdotla commented Aug 29, 2022 via email

@motdotla
Copy link
Owner

Things look good here. motdotla/dotenv#660 has been merged.

In the morning, I'll bump the version, release, and then merge and release this.

@FezVrasta
Copy link
Contributor

👋 sorry if I'm using this other PR but I see there's some activity here...

I sent a PR a while ago that fixes many parsing issues with this package, could it get reviewed please?

#74

@davemo
Copy link

davemo commented Aug 30, 2022

Thanks for the quick turnaround @motdotla ! ❤️

@motdotla
Copy link
Owner

Thank you for being understanding! 💛

Not as quick as it should be. I'm working on sponsorship now to better finance the time things take. We've also been building out https://github.com/dotenv-org/dotenv-vault which has a freemium model. Some of those funds will help go back into efforts to keep dotenv top notch opensource.

@motdotla motdotla merged commit 952eda5 into motdotla:master Aug 30, 2022
@motdotla
Copy link
Owner

Released as a major. https://www.npmjs.com/package/dotenv-expand/v/9.0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants