Add .github/ to .npmignore
#747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
Thank you for catching this. 100% agree. I will switch to an allowlist soon. |
|
Published as |
Vylpes
pushed a commit
to Vylpes/Droplet
that referenced
this pull request
Dec 25, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [dotenv](https://github.com/motdotla/dotenv) | dependencies | minor | [`16.0.3` -> `16.3.1`](https://renovatebot.com/diffs/npm/dotenv/16.0.3/16.3.1) | --- ### Release Notes <details> <summary>motdotla/dotenv (dotenv)</summary> ### [`v16.3.1`](https://github.com/motdotla/dotenv/blob/HEAD/CHANGELOG.md#1631-2023-06-17) [Compare Source](motdotla/dotenv@v16.3.0...v16.3.1) ##### Added - Add missing type definitions for `processEnv` and `DOTENV_KEY` options. [#​756](motdotla/dotenv#756) ### [`v16.3.0`](https://github.com/motdotla/dotenv/blob/HEAD/CHANGELOG.md#1630-2023-06-16) [Compare Source](motdotla/dotenv@v16.2.0...v16.3.0) ##### Added - Optionally pass `DOTENV_KEY` to options rather than relying on `process.env.DOTENV_KEY`. Defaults to `process.env.DOTENV_KEY` [#​754](motdotla/dotenv#754) ### [`v16.2.0`](https://github.com/motdotla/dotenv/blob/HEAD/CHANGELOG.md#1620-2023-06-15) [Compare Source](motdotla/dotenv@v16.1.4...v16.2.0) ##### Added - Optionally write to your own target object rather than `process.env`. Defaults to `process.env`. [#​753](motdotla/dotenv#753) - Add import type URL to types file [#​751](motdotla/dotenv#751) ### [`v16.1.4`](https://github.com/motdotla/dotenv/blob/HEAD/CHANGELOG.md#1614-2023-06-04) [Compare Source](motdotla/dotenv@v16.1.3...v16.1.4) ##### Added - Added `.github/` to `.npmignore` [#​747](motdotla/dotenv#747) ### [`v16.1.3`](https://github.com/motdotla/dotenv/blob/HEAD/CHANGELOG.md#1613-2023-05-31) [Compare Source](motdotla/dotenv@v16.1.2...v16.1.3) ##### Removed - Removed `browser` keys for `path`, `os`, and `crypto` in package.json. These were set to false incorrectly as of 16.1. Instead, if using dotenv on the front-end make sure to include polyfills for `path`, `os`, and `crypto`. [node-polyfill-webpack-plugin](https://github.com/Richienb/node-polyfill-webpack-plugin) provides these. ### [`v16.1.2`](https://github.com/motdotla/dotenv/blob/HEAD/CHANGELOG.md#1612-2023-05-31) [Compare Source](motdotla/dotenv@v16.1.1...v16.1.2) ##### Changed - Exposed private function `_configDotenv` as `configDotenv`. [#​744](motdotla/dotenv#744) ### [`v16.1.1`](https://github.com/motdotla/dotenv/blob/HEAD/CHANGELOG.md#1611-2023-05-30) [Compare Source](motdotla/dotenv@v16.1.0...v16.1.1) ##### Added - Added type definition for `decrypt` function ##### Changed - Fixed `{crypto: false}` in `packageJson.browser` ### [`v16.1.0`](https://github.com/motdotla/dotenv/blob/HEAD/CHANGELOG.md#1610-2023-05-30) [Compare Source](motdotla/dotenv@v16.0.3...v16.1.0) ##### Added - Add `populate` convenience method [#​733](motdotla/dotenv#733) - Accept URL as path option [#​720](motdotla/dotenv#720) - Add dotenv to `npm fund` command - Spanish language README [#​698](motdotla/dotenv#698) - Add `.env.vault` support. 🎉 ([#​730](motdotla/dotenv#730)) ℹ️ `.env.vault` extends the `.env` file format standard with a localized encrypted vault file. Package it securely with your production code deploys. It's cloud agnostic so that you can deploy your secrets anywhere – without [risky third-party integrations](https://techcrunch.com/2023/01/05/circleci-breach/). [read more](https://github.com/motdotla/dotenv#-deploying) ##### Changed - Fixed "cannot resolve 'fs'" error on tools like Replit [#​693](motdotla/dotenv#693) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4wLjAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4wLjAiLCJ0YXJnZXRCcmFuY2giOiJkZXZlbG9wIn0=--> Reviewed-on: https://gitea.vylpes.xyz/RabbitLabs/Droplet/pulls/250 Reviewed-by: Vylpes <ethan@vylpes.com> Co-authored-by: Renovate Bot <renovate@vylpes.com> Co-committed-by: Renovate Bot <renovate@vylpes.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a minor suggestion to omit some unnecessary files from the published package.
On a related note, I'd suggest switching from a blocklist to an allowlist approach. What I mean is to write
.npmignoresuch that you list files that should be published instead of files that shouldn't. The main advantage of this approach would be that it avoids publishing files unintentionally (most importantly files that aren't VCS tracked), but comes at the cost of having to be updated if new files should be included in the package. In my personal experience this trade-off is worth it.The following allowlist
.npmignorewould work for this project (note thatpackage.jsonis always published):