Pyqt5 more misplaced #408
Merged
Pyqt5 more misplaced #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove a non-existent misplaced member
|
Thanks for this. Looks like many things vanished in the upgrade to PySide6, good that they are still here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the PR twofer. I got pulled away before I could update my last one with this fix.
Looks like 80dc006 removed a chunk of misplaced members that shouldn't have been removed. Possibly because the key equals the value? In the other backends, it seems they got re-added, but not for PyQt5. I've added those back in.
Also
QItemSelectionandQItemSelectionRangeare handled by the_misplaced_membersmechanism, so they shouldn't be in_common_membersFinally, there were two remaps of QStringListModel in the PySide6 section, which look like they were copied from the PySide2 section. PySide6 doesn't have the issue that required the double remap, so I removed the unnecessary one.