Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Third milestone #4

Merged
merged 6 commits into from Mar 5, 2020
Merged

Third milestone #4

merged 6 commits into from Mar 5, 2020

Conversation

moudio
Copy link
Owner

@moudio moudio commented Mar 4, 2020

In this third milestone, I styled the components to obtain the required visual results. Here are the changes I made:

  • Change the display of the app to flex
  • Styling the display component to have a gray background, with a white and bold tex
  • Styling the rows to have a height of 100px
  • Styling the button component to have a width of 25%
  • Passing the "color" and "wide" props to the button and give a default value for each of them.

MauricioRobayo
MauricioRobayo approved these changes Mar 4, 2020
View reviewed changes
Copy link

@MauricioRobayo MauricioRobayo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

The project looks great and all requirements are met.

Status: Approved.

Left some optional comments for your consideration. They are not required.

src/Button.css Outdated Show resolved Hide resolved
src/components/Button.js Outdated Show resolved Hide resolved
@moudio moudio merged commit 8e2ed01 into develop Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MauricioRobayo MauricioRobayo MauricioRobayo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moudio @MauricioRobayo